Skip to content

Final parts of machine refactor#4925

Merged
gustovafing merged 55 commits into
1.20.1from
gus/more-trait-stuff
Jul 6, 2026
Merged

Final parts of machine refactor#4925
gustovafing merged 55 commits into
1.20.1from
gus/more-trait-stuff

Conversation

@gustovafing

@gustovafing gustovafing commented Jun 12, 2026

Copy link
Copy Markdown
Member

What

Final parts of machine refactor

  • Removal of IHasCircuitSlot in favour of circuit slot trait
  • Removal of IHasBatterySlot in favour of battery slot trait
  • Changes and documentation to a lot of machine ctors
  • Remove some machine/trait methods in favour of suppling values as ctor args
  • Add MachineInstanceFactory functional interface to represent machine ctors/creation functions
  • Merge IDropSaveMachine into metamachine
  • Remove IWorkableMultiblockMachine
  • Remove IMultiPart

# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/api/cover/CoverBehavior.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/trait/RecipeLogic.java
#	src/main/java/com/gregtechceu/gtceu/api/sync_system/SyncDataHolder.java
#	src/main/java/com/gregtechceu/gtceu/api/sync_system/data_transformers/ValueTransformer.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/electric/BlockBreakerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/electric/ItemCollectorMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/HPCAMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/ItemBusPartMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/steam/LargeBoilerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/steam/SteamMinerMachine.java
# Conflicts:
#	gradle/scripts/repositories.gradle
#	src/generated/resources/assets/gtceu/lang/en_ud.json
#	src/generated/resources/assets/gtceu/lang/en_us.json
#	src/main/java/com/gregtechceu/gtceu/api/cover/CoverBehavior.java
#	src/main/java/com/gregtechceu/gtceu/api/item/component/prospector/ProspectorMode.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTrait.java
#	src/main/java/com/gregtechceu/gtceu/api/registry/registrate/GTRegistrate.java
#	src/main/java/com/gregtechceu/gtceu/client/renderer/BlockHighlightRenderer.java
#	src/main/java/com/gregtechceu/gtceu/common/blockentity/CableBlockEntity.java
#	src/main/java/com/gregtechceu/gtceu/common/cover/ender/AbstractEnderLinkCover.java
#	src/main/java/com/gregtechceu/gtceu/common/item/behavior/MachineConfigCopyBehaviour.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/FusionReactorMachine.java
#	src/main/java/com/gregtechceu/gtceu/integration/embeddium/GTEmbeddiumCompat.java
#	src/main/java/com/gregtechceu/gtceu/integration/kjs/GregTechKubeJSPlugin.java
#	src/main/java/com/gregtechceu/gtceu/integration/map/ftbchunks/veins/ore/OreVeinIcon.java
#	src/main/java/com/gregtechceu/gtceu/integration/recipeviewer/jei/GTOreProcessingJeiCategory.java
#	src/main/java/com/gregtechceu/gtceu/integration/recipeviewer/rei/GTOreProcessingReiCategory.java
#	src/main/java/com/gregtechceu/gtceu/utils/GTStringUtils.java
@gustovafing gustovafing changed the title Gus/more trait stuff Final parts of machine refactor Jun 12, 2026
# Conflicts:
#	gradle/scripts/repositories.gradle
#	src/generated/resources/assets/gtceu/lang/en_ud.json
#	src/generated/resources/assets/gtceu/lang/en_us.json
#	src/main/java/com/gregtechceu/gtceu/client/renderer/BlockHighlightRenderer.java
#	src/main/java/com/gregtechceu/gtceu/common/cover/ender/AbstractEnderLinkCover.java
@github-actions github-actions Bot added the Tests: Failed Game Tests have failed on this PR label Jun 12, 2026
@jurrejelle jurrejelle added the Do Not Merge DO NOT MERGE THIS PR YET! label Jun 12, 2026
# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/api/machine/MetaMachine.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/MultiblockMachineDefinition.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/feature/multiblock/IMaintenanceMachine.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/mui/MachineUIPanelBuilder.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/MultiblockControllerMachine.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/WorkableMultiblockMachine.java
#	src/main/java/com/gregtechceu/gtceu/api/registry/registrate/MultiblockMachineBuilder.java
#	src/main/java/com/gregtechceu/gtceu/common/data/machines/GTResearchMachines.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/gcym/LargeChemicalBathMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/gcym/LargeMixerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/FluidHatchPartMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/ItemBusPartMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/RotorHolderPartMachine.java
#	src/main/java/com/gregtechceu/gtceu/integration/ae2/machine/MEStockingBusPartMachine.java
#	src/main/java/com/gregtechceu/gtceu/utils/data/TagCompatibilityFixer.java
@gustovafing gustovafing changed the base branch from mui2-refactor to 1.20.1 June 22, 2026 05:13
@gustovafing gustovafing marked this pull request as ready for review June 22, 2026 14:51
@gustovafing gustovafing requested a review from a team as a code owner June 22, 2026 14:51
# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/common/machine/electric/MinerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/ItemBusPartMachine.java
Comment thread src/main/java/com/gregtechceu/gtceu/config/ConfigHolder.java
Comment thread src/main/java/com/gregtechceu/gtceu/common/mui/GTMuiWidgets.java Outdated
Comment thread src/main/java/com/gregtechceu/gtceu/config/ConfigHolder.java
@github-actions github-actions Bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Jul 5, 2026

@jurrejelle jurrejelle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending possible cicd

@github-actions github-actions Bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Jul 5, 2026
@gustovafing gustovafing enabled auto-merge (squash) July 6, 2026 12:32
@gustovafing gustovafing merged commit 342f928 into 1.20.1 Jul 6, 2026
4 checks passed
@gustovafing gustovafing deleted the gus/more-trait-stuff branch July 6, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Tests: Passed Game Tests have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants